Upgrade to Thrift 0.19.0 (#807)

Update to Thrift 0.19 Co-authored-by: Courtney Wang <[email protected]> Co-authored-by: Katie Atkinson <[email protected]>
reddit · Dec 7, 2023 · 39a8c2e · 39a8c2e
1 parent c132681
commit 39a8c2e
Show file tree

Hide file tree

Showing 10 changed files with 22 additions and 10 deletions.
diff --git a/Dockerfile b/Dockerfile
@@ -1,4 +1,4 @@
-FROM ghcr.io/reddit/thrift-compiler:0.14.1 AS thrift
+FROM ghcr.io/reddit/thrift-compiler:0.19.0 AS thrift
 
 FROM python:3.9
 

diff --git a/baseplate/thrift/BaseplateService.py b/baseplate/thrift/BaseplateService.py
diff --git a/baseplate/thrift/BaseplateServiceV2.py b/baseplate/thrift/BaseplateServiceV2.py
diff --git a/baseplate/thrift/constants.py b/baseplate/thrift/constants.py
diff --git a/baseplate/thrift/ttypes.py b/baseplate/thrift/ttypes.py
diff --git a/requirements-transitive.txt b/requirements-transitive.txt
@@ -79,7 +79,7 @@ sphinxcontrib-jsmath==1.0.1
 sphinxcontrib-qthelp==1.0.3
 sphinxcontrib-serializinghtml==1.1.4
 SQLAlchemy==1.4.12
-thrift==0.14.1
+thrift-unofficial==0.19.0
 toml==0.10.2
 tomli==1.2.2
 translationstring==1.4

diff --git a/setup.py b/setup.py
@@ -44,7 +44,7 @@
         "posix_ipc>=1.0.0,<2.0",
         "python-json-logger>=2.0,<3.0",
         "requests>=2.21.0,<3.0",
-        "thrift>=0.14.1,<1.0",
+        "thrift-unofficial>=0.19.0,<1.0",
         "gevent>=20.5.0",
         "prometheus-client>=0.12.0",
     ],

diff --git a/tests/integration/test_thrift/TestService.py b/tests/integration/test_thrift/TestService.py
diff --git a/tests/integration/test_thrift/constants.py b/tests/integration/test_thrift/constants.py
diff --git a/tests/integration/test_thrift/ttypes.py b/tests/integration/test_thrift/ttypes.py