Don't fail to finalize observers if one fails #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradengroom
force-pushed
the
on-finish
branch
from
b210bc6
to
04e3f2b
Compare
bradengroom
changed the title
|
🐟 good call! |
|
🐟 lgtm |
KTAtkinson
requested changes
Oct 25, 2023
| try: | ||
| observer.on_finish(exc_info) | ||
| except Exception: | ||
| logger.exception("Exception raised while finalizing observer") |
There was a problem hiding this comment.
Please make it so this exception includes all the details the original exception would include. I don't want things to become harder to debug because we're catching this exception.
There was a problem hiding this comment.
logger.exception actually adds that information for us
https://docs.python.org/3/library/logging.html#logging.Logger.exception
KTAtkinson
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💸 TL;DR
When a request finishes, baseplate invokes
on_finishfor each observer. Sometimes these finalizers will fail and raise an exception. This causes the loop to exit early and we fail to finalize observers later in the loop. This could result in a few things including postgres sessions not getting closed timely. Raising from a finalizer also means we fail to clean up reference cycles later in the function and leave more work for GC to pick up later.📜 Details
N/A
🧪 Testing Steps / Validation
✅ Checks