Fix for the false positive of access-control's capabilities tcs. #2352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The forbidden capabilities test cases in access-control test suite are giving false positives. The code was stringifying the whole "capabilities" field and searching for the capability in the resulting string, which led to false positives when the capability was set in the "drop" list, as we've seen in a partner. The new code checks whether it was explicitly set in the Add list directly, matching by capability name or by "ALL".
sebrandon1
approved these changes
Aug 16, 2024
edcdavid
reviewed
Aug 16, 2024
edcdavid
approved these changes
Aug 16, 2024
sebrandon1
merged commit 6179120
into
redhat-best-practices-for-k8s:main
25 of 26 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The forbidden capabilities test cases in access-control test suite are giving false positives. The code was stringifying the whole "capabilities" field and searching for the capability in the resulting string, which led to false positives when the capability was set in the "drop" list, as we've seen in a partner.
The new code checks whether it was explicitly set in the Add list directly, matching by capability name or by "ALL".