Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for the false positive of access-control's capabilities tcs. #2352

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Fix for the false positive of access-control's capabilities tcs. #2352

merged 3 commits into from
Aug 19, 2024

Commits on Aug 16, 2024

  1. Fix for the false positive of access-control's capabilities tcs. 

    The forbidden capabilities test cases in access-control test suite are
giving false positives. The code was stringifying the whole
"capabilities" field and searching for the capability in the resulting
string, which led to false positives when the capability was set in the
"drop" list, as we've seen in a partner.

The new code checks whether it was explicitly set in the Add list
directly, matching by capability name or by "ALL".
    @greyerof
    greyerof committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    96e25ff View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix_access_control_capabilities_tcs

    @greyerof
    greyerof committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    e04424a View commit details
    Browse the repository at this point in the history

  3. v1 imports renamed to corev1

    @greyerof
    greyerof committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    900e75b View commit details
    Browse the repository at this point in the history