Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid failing workflow when collectors sanity check fails #2390

Conversation

shirmoran
Copy link
Contributor

This PR avoids failing pre-main workflow when collector's sanity check fails - instead it will only send a warning message to the our slack channel.

@dcibot
Copy link
Collaborator

dcibot commented Sep 1, 2024

@dcibot
Copy link
Collaborator

dcibot commented Sep 1, 2024

@dcibot
Copy link
Collaborator

dcibot commented Sep 1, 2024

Copy link
Contributor

@greyerof greyerof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should (hopefully) work once it's merged.

@greyerof greyerof merged commit b2fb84c into redhat-best-practices-for-k8s:main Sep 2, 2024
35 of 36 checks passed
@dcibot
Copy link
Collaborator

dcibot commented Sep 2, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants