Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid failing workflow when collectors sanity check fails #2390

Merged
merged 5 commits into from
Sep 2, 2024
Merged

Avoid failing workflow when collectors sanity check fails #2390

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2d537be
Avoid failing workflow when collectors sanity check fails
shirmoran Sep 1, 2024
b8ae43b
use step id to check failure
shirmoran Sep 1, 2024
0b05d1d
adjust message
shirmoran Sep 1, 2024
704ecbb
change param order - test
shirmoran Sep 1, 2024
de071b1
change param order - test
shirmoran Sep 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/pre-main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,11 +387,20 @@ jobs:
--label-filter="${SMOKE_TESTS_LABELS_FILTER}"

- name: Run sanity check on collector
id: collector_sanity_check
uses: ./collector/.github/actions/run-sanity-check
with:
working_directory: collector
collector_username: ${COLLECTOR_CIUSER}
collector_password: ${COLLECTOR_CIPASSWORD}
continue-on-error: true

- name: Send chat msg to dev team if collector's sanity check failed.
if: ${{ steps.collector_sanity_check.outcome == 'failure' }}
uses: ./.github/actions/slack-webhook-sender
with:
message: 'Collector sanity check has failed'
slack_webhook: '${{ secrets.SLACK_ALERT_WEBHOOK_URL }}'

- name: Upload container test results as an artifact
uses: actions/upload-artifact@834a144ee995460fba8ed112a2fc961b36a5ec5a # v4.3.6
Expand Down
Loading