Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

Detect bindable resource based on status attribute #1270

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Detect bindable resource based on status attribute #1270

merged 1 commit into from
Nov 10, 2022

Conversation

baijum
Copy link
Member

@baijum baijum commented Oct 13, 2022

Signed-off-by: Baiju Muthukadan [email protected]

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@baijum
Copy link
Member Author

baijum commented Oct 18, 2022

Closing this in favour of #1259

@baijum baijum closed this Oct 18, 2022
@baijum baijum reopened this Oct 20, 2022
@baijum baijum force-pushed the discovery-status branch 2 times, most recently from c7a1ed1 to 9226ef6 Compare October 21, 2022 11:48
@baijum baijum force-pushed the discovery-status branch 4 times, most recently from 1ae05c0 to dc6f553 Compare November 4, 2022 16:03
@codecov
Copy link

codecov bot commented Nov 4, 2022 •
edited
Loading

Codecov Report

Merging #1270 (f1c8a88) into master (29f6e70) will decrease coverage by 0.06%.
The diff coverage is 56.52%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1270      +/-   ##
==========================================
- Coverage   58.23%   58.16%   -0.07%     
==========================================
  Files          35       35              
  Lines        2988     3007      +19     
==========================================
+ Hits         1740     1749       +9     
- Misses       1082     1090       +8     
- Partials      166      168       +2
Impacted Files Coverage Δ
pkg/reconcile/pipeline/context/service/service.go 73.46% <56.52%> (-3.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29f6e70...f1c8a88. Read the comment docs.

@baijum baijum force-pushed the discovery-status branch 2 times, most recently from 59024f6 to 5734d3b Compare November 7, 2022 13:28
@baijum baijum requested a review from sadlerap November 7, 2022 16:14
sadlerap
sadlerap reviewed Nov 7, 2022
View reviewed changes
Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far, but I'd maybe like to see some tests (either some unit tests or some acceptance tests). I'm a little suspicious of the JSONPath lookup; IMO it's something that could be fragile if we're not careful.

@baijum
Copy link
Member Author

baijum commented Nov 8, 2022

LGTM so far, but I'd maybe like to see some tests (either some unit tests or some acceptance tests). I'm a little suspicious of the JSONPath lookup; IMO it's something that could be fragile if we're not careful.

I have added unit tests. There is an existing acceptance test which I have updated the test data.

@baijum
Copy link
Member Author

baijum commented Nov 8, 2022

/test 4.12-acceptance

@baijum baijum requested a review from sadlerap November 8, 2022 18:32
sadlerap
sadlerap approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 9, 2022
@openshift-ci openshift-ci bot removed the lgtm label Nov 9, 2022
@pmacik
Copy link
Contributor

pmacik commented Nov 10, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 10, 2022
@baijum
Copy link
Member Author

baijum commented Nov 10, 2022

/retest

@sadlerap
Copy link
Contributor

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadlerap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 50365e4 into redhat-developer:master Nov 10, 2022
@baijum baijum deleted the discovery-status branch November 11, 2022 04:25
@baijum baijum mentioned this pull request Nov 11, 2022
Closed
pmacik pushed a commit to pmacik/service-binding-operator that referenced this pull request Jan 10, 2023
@baijum @pmacik
Detect bindable resource based on status attribute (redhat-developer#…
62e7704 
…1270)

Signed-off-by: Baiju Muthukadan <[email protected]>

Signed-off-by: Baiju Muthukadan <[email protected]>
pmacik pushed a commit to pmacik/service-binding-operator that referenced this pull request Jan 11, 2023
@baijum @pmacik
Detect bindable resource based on status attribute (redhat-developer#…
fb59811 
…1270)

Signed-off-by: Baiju Muthukadan <[email protected]>

Signed-off-by: Baiju Muthukadan <[email protected]>
openshift-merge-robot pushed a commit that referenced this pull request Jan 12, 2023
@pmacik @baijum
Detect bindable resource based on status attribute (#1270) (#1357)
89cdc44 
Signed-off-by: Baiju Muthukadan <[email protected]>

Signed-off-by: Baiju Muthukadan <[email protected]>

Signed-off-by: Baiju Muthukadan <[email protected]>
Co-authored-by: Baiju Muthukadan <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sadlerap sadlerap sadlerap approved these changes

@dperaza4dustbit dperaza4dustbit Awaiting requested review from dperaza4dustbit

@filariow filariow Awaiting requested review from filariow

Assignees

@pmacik pmacik

@sadlerap sadlerap

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@baijum @pmacik @sadlerap @openshift-merge-robot