Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

cherry-pick(release-v1.3.x): Detect bindable resource based on status attribute #1357

Merged
merged 1 commit into from
Jan 12, 2023
Merged

cherry-pick(release-v1.3.x): Detect bindable resource based on status attribute #1357

merged 1 commit into from
Jan 12, 2023

Conversation

pmacik
Copy link
Contributor

@pmacik pmacik commented Jan 10, 2023

Signed-off-by: Baiju Muthukadan [email protected]

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@pmacik pmacik added cherry-pick release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch labels Jan 10, 2023
@pmacik pmacik added this to the 1.3.3 milestone Jan 10, 2023
@pmacik
Copy link
Contributor Author

pmacik commented Jan 11, 2023

/retest

@codecov
Copy link

codecov bot commented Jan 11, 2023 •
edited
Loading

Codecov Report

Merging #1357 (fb59811) into release-v1.3.x (7614578) will decrease coverage by 0.07%.
The diff coverage is 56.52%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-v1.3.x    #1357      +/-   ##
==================================================
- Coverage           58.06%   57.99%   -0.08%     
==================================================
  Files                  33       33              
  Lines                2797     2816      +19     
==================================================
+ Hits                 1624     1633       +9     
- Misses               1018     1026       +8     
- Partials              155      157       +2
Impacted Files Coverage Δ
pkg/reconcile/pipeline/context/service/service.go 73.46% <56.52%> (-3.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7614578...fb59811. Read the comment docs.

@pmacik
Copy link
Contributor Author

pmacik commented Jan 11, 2023

Depends on #1358

@pmacik pmacik force-pushed the cherry-pick_release-v1.3.x_50365e40_12f2de01-e015-44b0-8fc2-ac2fb595e311 branch from 62e7704 to fb59811 Compare January 11, 2023 22:42
@pmacik
Copy link
Contributor Author

pmacik commented Jan 11, 2023

/retest

1 similar comment
@pmacik
Copy link
Contributor Author

pmacik commented Jan 12, 2023

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 89cdc44 into redhat-developer:release-v1.3.x Jan 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dperaza4dustbit dperaza4dustbit Awaiting requested review from dperaza4dustbit

@sadlerap sadlerap Awaiting requested review from sadlerap

Assignees
No one assigned
Labels
approved cherry-pick lgtm release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch
Projects
None yet
Milestone
1.3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@pmacik @openshift-merge-robot @baijum