Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

Conversation

service-binding-operator-bot
Copy link
Collaborator

If required tool version is found on the host, then it will be linked into the ./bin folder. Otherwise, it will be downloaded.

Signed-off-by: Francesco Ilario [email protected]

Changes

Added install-tools and local-env rules to makefiles.
Leveraging on these rules, it is now possible to easily install the needed version of each dependency.

/kind enhancement

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@service-binding-operator-bot service-binding-operator-bot added approved cherry-pick kind/enhancement New feature or request lgtm release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch labels Oct 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…1280)

If required tool version is found on the host, then it will be linked
into the ./bin folder. Otherwise, it will be downloaded.

Signed-off-by: Francesco Ilario <[email protected]>

Signed-off-by: Francesco Ilario <[email protected]>
@pmacik pmacik force-pushed the cherry-pick_release-v1.3.x_b983cfca_14af641e-d3e1-4b5a-bf6a-25b15783dc7d branch from 932f2ac to 74337c3 Compare October 25, 2022 14:51
@openshift-ci openshift-ci bot removed the lgtm label Oct 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 25, 2022

New changes are detected. LGTM label has been removed.

@pmacik pmacik added the lgtm label Oct 25, 2022
@openshift-merge-robot openshift-merge-robot merged commit 569067b into redhat-developer:release-v1.3.x Oct 25, 2022
@service-binding-operator-bot service-binding-operator-bot deleted the cherry-pick_release-v1.3.x_b983cfca_14af641e-d3e1-4b5a-bf6a-25b15783dc7d branch October 25, 2022 17:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved cherry-pick kind/enhancement New feature or request lgtm release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants