This repository has been archived by the owner on Jun 26, 2024. It is now read-only.
Add install-tools and local-env rules to Makefiles #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1280 +/- ##
=======================================
Coverage 58.06% 58.06%
=======================================
Files 33 33
Lines 2797 2797
=======================================
Hits 1624 1624
Misses 1018 1018
Partials 155 155 Continue to review full report at Codecov.
|
filariow
force-pushed
the
pr-install-tools
branch
from
64fd7e5
to
9d47f28
Compare
filariow
force-pushed
the
pr-install-tools
branch
5 times, most recently
from
b9a3080
to
cb11828
Compare
pmacik
added
release/v1.2.x
pmacik
reviewed
Oct 24, 2022
If required tool version is found on the host, then it will be linked into the ./bin folder. Otherwise, it will be downloaded. Signed-off-by: Francesco Ilario <[email protected]>
filariow
force-pushed
the
pr-install-tools
branch
from
cb11828
to
a1f1591
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pmacik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
service-binding-operator-bot
pushed a commit
to service-binding-operator-bot/service-binding-operator
that referenced
this pull request
Oct 24, 2022
…1280) If required tool version is found on the host, then it will be linked into the ./bin folder. Otherwise, it will be downloaded. Signed-off-by: Francesco Ilario <[email protected]> Signed-off-by: Francesco Ilario <[email protected]>
service-binding-operator-bot
pushed a commit
to service-binding-operator-bot/service-binding-operator
that referenced
this pull request
Oct 24, 2022
…1280) If required tool version is found on the host, then it will be linked into the ./bin folder. Otherwise, it will be downloaded. Signed-off-by: Francesco Ilario <[email protected]> Signed-off-by: Francesco Ilario <[email protected]>
openshift-merge-robot
pushed a commit
that referenced
this pull request
Oct 24, 2022
If required tool version is found on the host, then it will be linked into the ./bin folder. Otherwise, it will be downloaded. Signed-off-by: Francesco Ilario <[email protected]> Signed-off-by: Francesco Ilario <[email protected]> Signed-off-by: Francesco Ilario <[email protected]> Co-authored-by: Francesco Ilario <[email protected]>
pmacik
pushed a commit
to service-binding-operator-bot/service-binding-operator
that referenced
this pull request
Oct 25, 2022
…1280) If required tool version is found on the host, then it will be linked into the ./bin folder. Otherwise, it will be downloaded. Signed-off-by: Francesco Ilario <[email protected]> Signed-off-by: Francesco Ilario <[email protected]>
openshift-merge-robot
pushed a commit
that referenced
this pull request
Oct 25, 2022
If required tool version is found on the host, then it will be linked into the ./bin folder. Otherwise, it will be downloaded. Signed-off-by: Francesco Ilario <[email protected]> Signed-off-by: Francesco Ilario <[email protected]> Signed-off-by: Francesco Ilario <[email protected]> Co-authored-by: Francesco Ilario <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If required tool version is found on the host, then it will be linked into the ./bin folder. Otherwise, it will be downloaded.
Signed-off-by: Francesco Ilario [email protected]
Changes
Added
install-toolsandlocal-envrules to makefiles.Leveraging on these rules, it is now possible to easily install the needed version of each dependency.
/kind enhancement
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
included if any changes are user facing
included if any functionality added or changed. For bugfixes please include tests that can catch regressions
@external-feedbacktag.