Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

Conversation

service-binding-operator-bot
Copy link
Collaborator

If required tool version is found on the host, then it will be linked into the ./bin folder. Otherwise, it will be downloaded.

Signed-off-by: Francesco Ilario [email protected]

Changes

Added install-tools and local-env rules to makefiles.
Leveraging on these rules, it is now possible to easily install the needed version of each dependency.

/kind enhancement

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

…1280)

If required tool version is found on the host, then it will be linked
into the ./bin folder. Otherwise, it will be downloaded.

Signed-off-by: Francesco Ilario <[email protected]>

Signed-off-by: Francesco Ilario <[email protected]>
@service-binding-operator-bot service-binding-operator-bot added approved cherry-pick kind/enhancement New feature or request lgtm release/v1.2.x Used to mark PRs to be cherry-picked in release-v1.2.x branch labels Oct 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #1289 (642c05c) into release-v1.2.x (480d9d1) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release-v1.2.x    #1289   +/-   ##
===============================================
  Coverage           58.05%   58.05%           
===============================================
  Files                  33       33           
  Lines                2844     2844           
===============================================
  Hits                 1651     1651           
  Misses               1032     1032           
  Partials              161      161           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 480d9d1...642c05c. Read the comment docs.

@openshift-merge-robot openshift-merge-robot merged commit ba06a40 into redhat-developer:release-v1.2.x Oct 24, 2022
@service-binding-operator-bot service-binding-operator-bot deleted the cherry-pick_release-v1.2.x_b983cfca_17461557-38f9-4808-a0ec-eb04f884b0fd branch October 24, 2022 15:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved cherry-pick kind/enhancement New feature or request lgtm release/v1.2.x Used to mark PRs to be cherry-picked in release-v1.2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants