Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add completion for 'conditionRef' in Pipeline conditions #244

Closed
evidolob opened this issue Apr 13, 2020 · 0 comments · Fixed by #337
Closed

Add completion for 'conditionRef' in Pipeline conditions #244

evidolob opened this issue Apr 13, 2020 · 0 comments · Fixed by #337
Assignees
@evidolob
Labels
enhancement New feature or request size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Milestone
Sprint #186

Comments

@evidolob
Copy link
Collaborator

We can collect all deployed conditions in a cluster and put their names in JSON scheme for pipeline, to provide completion.
@evidolob evidolob added enhancement New feature or request size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 13, 2020
@evidolob evidolob added this to the Sprint #186 milestone Jun 18, 2020
@evidolob evidolob self-assigned this Jul 6, 2020
evidolob added a commit that referenced this issue Jul 7, 2020
@evidolob
#244 add completion for 'conditionRef' field
bdfdd83 
Signed-off-by: Yevhen Vydolob <[email protected]>
@evidolob evidolob mentioned this issue Jul 7, 2020
Merged
evidolob added a commit that referenced this issue Jul 9, 2020
@evidolob
Add completion for 'conditionRef' field (#337)
416cd9e 
* #244 add completion for 'conditionRef' field

Signed-off-by: Yevhen Vydolob <[email protected]>

* add tests

Signed-off-by: Yevhen Vydolob <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evidolob evidolob

Labels
enhancement New feature or request size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Sprint #186
Development

Successfully merging a pull request may close this issue.

Add completion for 'conditionRef' field redhat-developer/vscode-tekton
1 participant
@evidolob