Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completion for 'conditionRef' field #337

Merged
merged 2 commits into from
Jul 9, 2020
Merged

Conversation

evidolob
Copy link
Collaborator

@evidolob evidolob commented Jul 7, 2020

Fix: #244

Demo:
ezgif com-video-to-gif (25)

@evidolob evidolob self-assigned this Jul 7, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2020

Codecov Report

Merging #337 into master will decrease coverage by 0.00%.
The diff coverage is 78.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #337      +/-   ##
==========================================
- Coverage   73.87%   73.87%   -0.01%     
==========================================
  Files          46       47       +1     
  Lines        3415     3433      +18     
  Branches      635      637       +2     
==========================================
+ Hits         2523     2536      +13     
- Misses        892      897       +5     
Impacted Files Coverage Δ
src/yaml-support/tkn-yaml-scheme-generator.ts 31.70% <44.44%> (-0.65%) ⬇️
src/yaml-support/tkn-conditions-provider.ts 100.00% <100.00%> (ø)
src/yaml-support/tkn-tasks-provider.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8413a9...f2c0538. Read the comment docs.

Signed-off-by: Yevhen Vydolob <[email protected]>
@evidolob evidolob merged commit 416cd9e into master Jul 9, 2020
@evidolob evidolob deleted the condition-ref-completion branch July 9, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add completion for 'conditionRef' in Pipeline conditions
2 participants