Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If a registeredContributor of schema provider is throwing an error, it is forbidding other registered schema providers to work #323

Closed
apupier opened this issue Jul 22, 2020 · 2 comments
Closed

If a registeredContributor of schema provider is throwing an error, it is forbidding other registered schema providers to work #323

apupier opened this issue Jul 22, 2020 · 2 comments
Assignees
@apupier
Labels
bug
Milestone
0.9.0

Comments

@apupier
Copy link
Member

apupier commented Jul 22, 2020

steps to reproduce:

  • provide your own schema provider whcih is an array
  • install VS Code Kuerbetes extension
  • put text - in the file
  • VS Code Kubernetes is throwing an error, it prevents other registered schema providers to be evaluated
@apupier apupier self-assigned this Jul 22, 2020
@apupier apupier mentioned this issue Jul 22, 2020
Merged
apupier added a commit to apupier/vscode-yaml that referenced this issue Jul 22, 2020
@apupier
Catch errors that can be thrown by registered schema providers redhat…
8f2ca66 
…-developer#323

in case, one of the registered is throwing an error, it avoids to break
the other registered ones.

Signed-off-by: Aurélien Pupier <[email protected]>
@apupier apupier mentioned this issue Jul 23, 2020
Closed
JPinkney added a commit that referenced this issue Jul 24, 2020
@JPinkney
Merge pull request #324 from apupier/323-catchThrownErrorInOtherExten…
2dfb3d5 
…sions

Catch errors that can be thrown by registered schema providers #323
JPinkney added a commit that referenced this issue Jul 24, 2020
@JPinkney
Revert "Catch errors that can be thrown by registered schema providers …
70717c9 
…#323"
JPinkney added a commit that referenced this issue Jul 24, 2020
@JPinkney
Merge pull request #330 from redhat-developer/revert-324-323-catchThr…
397c37d 
…ownErrorInOtherExtensions

Revert "Catch errors that can be thrown by registered schema providers #323"
@gorkem gorkem added the bug label Jul 30, 2020
@apupier apupier added this to the 0.9.0 milestone Aug 17, 2020
@gorkem
Copy link
Collaborator

gorkem commented Dec 18, 2020

@apupier Is this fixed now?

@apupier
Copy link
Member Author

apupier commented Dec 18, 2020

this test

vscode-yaml/test/schemaProvider.test.ts

Line 141 in bbd041c

it('Multiple contributors with one throwing an error', async () => {
tends to mean yes.

@apupier apupier closed this as completed Dec 18, 2020
@ssbarnea ssbarnea mentioned this issue May 18, 2022
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apupier apupier

Labels
bug
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
2 participants
@gorkem @apupier