Catch errors that can be thrown by registered schema providers #323 #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-developer#323 in case, one of the registered is throwing an error, it avoids to break the other registered ones. Signed-off-by: Aurélien Pupier <[email protected]>
apupier
commented
Jul 22, 2020
| matches.push(uri); | ||
| } | ||
| } catch (error) { | ||
| console.log(`Error thrown while requesting schema ` + error); |
There was a problem hiding this comment.
is there an output channel where this error can be logged? or we keep it at console level so only developers will see it?
There was a problem hiding this comment.
+1 to have output channel, we need provide, as much as possible, information when something goes wrong.
There was a problem hiding this comment.
I think it is better to handle it in a separate PR as it is a distinct feature to have an outputchannel. i created #327
JPinkney
reviewed
Jul 22, 2020
Co-authored-by: Josh Pinkney <[email protected]>
This was referenced Jul 23, 2020
Merged
|
I will be on PTO for 3 weeks. Feel free to modify/merge and release a new version with it :-) |
JPinkney
approved these changes
Jul 24, 2020
|
@apupier I've approved and now I'll merge. Have a good PTO! |
|
Actually I'm going to revert and instead merge #327 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in case, one of the registered is throwing an error, it avoids to break
the other registered ones.
Signed-off-by: Aurélien Pupier [email protected]