Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an output channel #327

Merged
merged 3 commits into from
Jul 24, 2020
Merged

Conversation

apupier
Copy link
Member

@apupier apupier commented Jul 23, 2020

for instance, currently with VS Code Kubernetes extension which is throwing error with - file content:
Screenshot from 2020-07-23 10-42-45

requires #324

@JPinkney
Copy link
Contributor

Is there anyway we can re-use the "YAML Support" output channel instead of creating a new one? The output channel name is automatically taken from: https://github.com/redhat-developer/vscode-yaml/blob/master/src/extension.ts#L60

@apupier
Copy link
Member Author

apupier commented Jul 23, 2020

it is possible but it will mix the information coming from the Yaml Language Server and from the extension itself.

@JPinkney
Copy link
Contributor

I think that's fine. I think users will be confused when there are two output channels for the same project.

By default yaml.trace.server is "off" anyways so the information from the language server is exposed only when they set yaml.trace.server to messages or verbose

@JPinkney JPinkney merged commit e6420dc into redhat-developer:master Jul 24, 2020
bleach31 pushed a commit to bleach31/vscode-yaml that referenced this pull request Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants