Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code bundling with webpack #596

Merged
merged 4 commits into from
Sep 24, 2021

Conversation

evidolob
Copy link
Collaborator

@evidolob evidolob commented Sep 15, 2021

What does this PR do?

This PR based on #591 @fbricon work.
It just add bundling of yaml-ls in languageserver.js file.

Note: I keep prettier unbundled as it contains quite big and already bundled files.

For me vscode shows 78ms activation time with this PR, comparing to 303ms for 0.22.0 version
And vsix file now contains 50 files, 4.23MB size, comparing to 1829 files, 8.5MB for 0.22.0.

The only thing that we may loose that error stack traces now doesn't contains any readable names, so it would be hard to find problem if user/telemetry report any trace.

What issues does this PR fix or reference?

#521

Is it tested? How?

fbricon and others added 2 commits September 13, 2021 10:36
Signed-off-by: Fred Bricon <[email protected]>
Signed-off-by: Yevhen Vydolob <[email protected]>
Signed-off-by: Yevhen Vydolob <[email protected]>
@fbricon
Copy link
Contributor

fbricon commented Sep 15, 2021

Can we trim some prettier fat? You should just need parser-yaml
Screenshot 2021-09-15 at 17 42 53

@evidolob
Copy link
Collaborator Author

@fbricon I include in vsix package only needed prettier files, now package contains 20 files, 840.42KB
But we need to double check that everything works well

@gorkem gorkem mentioned this pull request Sep 19, 2021
Copy link
Collaborator

@gorkem gorkem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have built and tested briefly, no problems and seems like an improvement.

@evidolob evidolob merged commit af9cd09 into redhat-developer:main Sep 24, 2021
@evidolob evidolob deleted the fbricon-webpack branch September 24, 2021 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants