Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize packaging with webpack #521

Closed
fbricon opened this issue May 26, 2021 · 0 comments
Closed

Optimize packaging with webpack #521

fbricon opened this issue May 26, 2021 · 0 comments
Assignees
Milestone

Comments

@fbricon
Copy link
Contributor

fbricon commented May 26, 2021

Is your enhancement related to a problem? Please describe.

vscode-yaml vsix is about 9MB big, turns out it's mostly because of the embedded node_modules directory

Describe the solution you would like

Webpack would allow to optimize the build output and hopefully make the extension leaner and faster do download

@evidolob evidolob self-assigned this Sep 13, 2021
@evidolob evidolob added this to the 0.23.0 milestone Sep 13, 2021
bleach31 pushed a commit to bleach31/vscode-yaml that referenced this issue Jan 25, 2022
The intention was to enforce developers of the project to use a minimal version
of yarn. However, the yarn and npm engines determine which version of those
package managers may be used to install `yaml-language-server`. This caused
warnings for users using npm or older yarn versions.

The node engines field signals required node version that’s needed. Setting it
to `*` is equivalent to not setting it at all.

Closes redhat-developer#521
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants