Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatter must unregister when being disabled #136

Closed
jrieken opened this issue Mar 13, 2019 · 2 comments
Closed

Formatter must unregister when being disabled #136

jrieken opened this issue Mar 13, 2019 · 2 comments
Assignees
Labels

Comments

@jrieken
Copy link

jrieken commented Mar 13, 2019

A formatter that is registered with VSCode must be unregistered when the formatter is being disabled. Otherwise VSCode still thinks a formatter is available, enabling formatting actions and contributing to the problem of conflicting formatters. See microsoft/vscode#70314 for more details on the topic and feel free to reach out to us for further questions.

Thanks & HappyCoding

@NikolasKomonen
Copy link

@JPinkney Are you working on this issue already? I'll work on it if you haven't started yet.

@JPinkney
Copy link
Contributor

@NikolasKomonen I haven't started it, you'll just have to make sure its consistent with the changes in #126 (which I'll probably fixup tomorrow night)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants