Fix formatter #126
Merged
Fix formatter #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walles
reviewed
Mar 6, 2019
src/server.ts
Outdated
| @@ -230,6 +231,9 @@ connection.onDidChangeConfiguration((change) => { | |||
| if (settings.yaml.format.bracketSpacing === false) { | |||
| yamlFormatterSettings.bracketSpacing = false; | |||
| } | |||
| if (settings.yaml.format.enable) { | |||
| yamlFormatterSettings.enable = settings.yaml.format.enable || true; | |||
There was a problem hiding this comment.
Maybe I'm misunderstanding something here, but will this ever set yamlFormatterSettings.enable to false?
If settings.yaml.format.enable is false, won't this code block just be ignored?
There was a problem hiding this comment.
And won't the || true ensure that this would always be set to true anyway?
But I'm bad at Javascript so maybe this actually works.
There was a problem hiding this comment.
Yep! Good catch! I must not have had my coffee yet when I made the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the formatter so that it respects the yaml.format.enable setting.