Fix 'fileMatch' pattern to match whole file name #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yevhen Vydolob <[email protected]>
JPinkney
approved these changes
Mar 1, 2021
|
Does not look like you added a test for this. |
Signed-off-by: Yevhen Vydolob <[email protected]>
joshuawilson
reviewed
Mar 2, 2021
| // ignore | ||
| }); | ||
| try { | ||
| const schemaStore = await this.getSchemaStoreMatchingSchemas(); |
There was a problem hiding this comment.
I do not see where you are stubbing this promise in the test.
There was a problem hiding this comment.
Because I don't stub it, I stub xhr function https://github.com/redhat-developer/yaml-language-server/pull/417/files#diff-9c120b6ffef26acf5a9470c86608e41b18520b4ebdb317aded945ab236739631R40 which used in getSchemaStoreMatchingSchemas as the reasl code which I want to test is inside getSchemaStoreMatchingSchemas.
There was a problem hiding this comment.
I was wondering if that might be the case. Thanks for clearing that up.
joshuawilson
approved these changes
Mar 2, 2021
JPinkney
approved these changes
Mar 2, 2021
evidolob
added a commit
to evidolob/yaml-language-server
that referenced
this pull request
Mar 25, 2021
Signed-off-by: Yevhen Vydolob <[email protected]>
evidolob
added a commit
that referenced
this pull request
Apr 6, 2021
Signed-off-by: Yevhen Vydolob <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It add
/to file match pattern, if pattern doesn't include it.The original problem in
vscode-json-languageservice, it the way how file match implemented there.Basically it match only file name end(i.e.
arc.yamland.mocharc.yamlfile patterns will match to/some/path/.mocharc.yaml)This PR is basically, trying to workaround that behaviour, by forcing matching against full file name.
vscode-json-languageservicehas similar issues:Demo:
What issues does this PR fix or reference?
Fix: redhat-developer/vscode-yaml#354
and fix: redhat-developer/vscode-yaml#397
Is it tested? How?
Just create
.mocharc.yamlfile, open it and make sure that JSON Schema selected properly.