Use 'markdownDescription' for property completion #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yevhen Vydolob <[email protected]>
| required: ['kind'], | ||
| }); | ||
|
|
||
| const content = 'kin'; |
There was a problem hiding this comment.
It should be kin to test completion to kind
joshuawilson
approved these changes
Mar 25, 2021
JPinkney
reviewed
Mar 25, 2021
There was a problem hiding this comment.
I think we might have to add a CompletionClientCapabilities check for the documentationFormat. If I'm understanding the spec correctly, under https://microsoft.github.io/language-server-protocol/specification#textDocument_completion it looks like clients can specify what documentation formats they support in completionItem.documentationFormat
|
@JPinkney In all cases we use fromMarkup Which already has such check. |
…rver into fix-i417 Signed-off-by: Yevhen Vydolob <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use 'markdownDescription' for property completion.
Demo:
What issues does this PR fix or reference?
Fix: redhat-developer/vscode-yaml#417
Is it tested? How?
With test