Initial work on adopting new parser #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
| class CommonTagImpl { | ||
| public tag: string; | ||
| public readonly type: string; | ||
| default: never; |
There was a problem hiding this comment.
public is the default. If you left it off to make it private it will not work. It would be better to be consistent and use public on all public fields or none of them.
This was referenced Jun 15, 2021
implements a new converter that converts eemeli yaml parser AST to internal AST.
Signed-off-by: Yevhen Vydolob <[email protected]>
Fixes the conversion of warnings from parser AST.
Implement a generic tag implementation to support custom tags from settings.
Implements the include tag and validates for empty values. Updates the test which gives a more accurate range for error.
Updates the tests to new parser message and range.
Updates tests that require YAML 1.1 behaviour to include %YAML 1.1 directive.
Signed-off-by: Yevhen Vydolob <[email protected]>
* Fix "Billion Laughs" attack and validation tests Signed-off-by: Yevhen Vydolob <[email protected]> * Fix vslidation tests Signed-off-by: Yevhen Vydolob <[email protected]>
Adjusts the duplicate key error tests to the message from new parser. Also updates the test for a single error instead of multiple errors.
* Upgrade yaml parser to latest version Signed-off-by: Yevhen Vydolob <[email protected]> * and fix one more test Signed-off-by: Yevhen Vydolob <[email protected]>
* Use new AST in completion Signed-off-by: Yevhen Vydolob <[email protected]> * Fix validation Signed-off-by: Yevhen Vydolob <[email protected]> * Add tests, fix review comments Signed-off-by: Yevhen Vydolob <[email protected]>
Signed-off-by: Yevhen Vydolob <[email protected]>
evidolob
force-pushed
the
parser-switch
branch
from
f5ee3c8
to
6dcf712
Compare
|
I can not really approve this PR since I am the author but please go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing the parser with eemeli yaml parser AST to internal AST.