Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace js-yaml with yaml #526

Merged
merged 2 commits into from
Aug 23, 2021

Conversation

remcohaszing
Copy link
Contributor

What does this PR do?

In #442 yaml-language-server-parser is being replaced with yaml for parsing the AST. yaml can also replace js-yaml for parsing YAML in other places. This saves a dependency.

What issues does this PR fix or reference?

N/A

Is it tested? How?

Existing unittests didn’t break.

@coveralls
Copy link

coveralls commented Aug 22, 2021

Coverage Status

Coverage increased (+0.1%) to 78.492% when pulling 0c3ee7a on remcohaszing:replace-js-yaml into 4819456 on redhat-developer:main.

@evidolob
Copy link
Collaborator

@remcohaszing Could you update package.json with main?

@remcohaszing
Copy link
Contributor Author

Done 😄

@evidolob evidolob merged commit 6aaf078 into redhat-developer:main Aug 23, 2021
@remcohaszing remcohaszing deleted the replace-js-yaml branch February 13, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants