Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package code with webpack #540

Closed
wants to merge 1 commit into from

Conversation

evidolob
Copy link
Collaborator

What does this PR do?

Add package yaml-ls code with webpack. New bundled script is in./out/server/language_server.js.
Bundle contains all yaml-ls dependencies except prettier. As it quite huge(~ 10Mb scripts) and including it in webpack bundle breaks debugging.

Note: To keep backward compatibility, I left compilation with pure ts, so old ./out/server/src/server.js should work.

What issues does this PR fix or reference?

redhat-developer/vscode-yaml#521

Is it tested? How?

Signed-off-by: Yevhen Vydolob <[email protected]>
@evidolob evidolob self-assigned this Sep 15, 2021
@coveralls
Copy link

coveralls commented Sep 15, 2021

Coverage Status

Coverage increased (+0.1%) to 78.474% when pulling 83b27df on evidolob:use-webpack into 40b6fe4 on redhat-developer:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants