Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pipelining from UnifiedJedis #3221

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Conversation

sazzad16
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

Codecov Report

Base: 66.90% // Head: 67.05% // Increases project coverage by +0.15% 🎉

Coverage data is based on head (5033911) compared to base (11a4513).
Patch coverage: 76.47% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3221      +/-   ##
============================================
+ Coverage     66.90%   67.05%   +0.15%     
- Complexity     4546     4581      +35     
============================================
  Files           248      248              
  Lines         14738    14747       +9     
  Branches        916      917       +1     
============================================
+ Hits           9860     9889      +29     
+ Misses         4487     4463      -24     
- Partials        391      395       +4     
Impacted Files Coverage Δ
...c/main/java/redis/clients/jedis/JedisSharding.java 68.75% <0.00%> (-4.59%) ⬇️
...rc/main/java/redis/clients/jedis/UnifiedJedis.java 75.23% <50.00%> (+3.25%) ⬆️
...rc/main/java/redis/clients/jedis/JedisCluster.java 32.43% <66.66%> (+0.92%) ⬆️
src/main/java/redis/clients/jedis/JedisPooled.java 27.90% <100.00%> (+0.56%) ⬆️
src/main/java/redis/clients/jedis/Pipeline.java 17.15% <100.00%> (+0.18%) ⬆️
...in/java/redis/clients/jedis/ConnectionFactory.java 63.26% <0.00%> (-4.09%) ⬇️
...ava/redis/clients/jedis/JedisClusterInfoCache.java 72.50% <0.00%> (-3.13%) ⬇️
src/main/java/redis/clients/jedis/JedisPubSub.java 70.00% <0.00%> (-1.82%) ⬇️
src/main/java/redis/clients/jedis/Protocol.java 90.62% <0.00%> (-1.25%) ⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sazzad16
Copy link
Collaborator Author

Related #2767

Copy link
Collaborator

@yangbodong22011 yangbodong22011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,Greate Job~

@sazzad16 sazzad16 merged commit ed57047 into redis:master Dec 5, 2022
@sazzad16 sazzad16 deleted the pipe-more branch December 5, 2022 12:55
@sazzad16
Copy link
Collaborator Author

sazzad16 commented Dec 5, 2022

@yangbodong22011 About broadcasting, do you prefer any of #3211 or #3194

@yangbodong22011
Copy link
Collaborator

@yangbodong22011 About broadcasting, do you prefer any of #3211 or #3194

I will review and give my opinion as soon as possible

sazzad16 added a commit to sazzad16/jedis that referenced this pull request Aug 31, 2023
This is an expansion of redis#3221, as well as redis#3240. This is requested in redis#3516.
sazzad16 added a commit that referenced this pull request Aug 31, 2023
This is an expansion of #3221, as well as #3240. This is requested in #3516.
sazzad16 added a commit that referenced this pull request Aug 31, 2023
This is an expansion of #3221, as well as #3240. This is requested in #3516.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants