Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Sentinel mode with UnifiedJedis #3240

Merged
merged 2 commits into from
Dec 13, 2022

Conversation

sazzad16
Copy link
Collaborator

@sazzad16 sazzad16 commented Dec 11, 2022

Resolves #2754
Addresses #2864

@sazzad16 sazzad16 marked this pull request as draft December 11, 2022 16:17
@sazzad16 sazzad16 marked this pull request as ready for review December 12, 2022 10:42
@codecov-commenter
Copy link

Codecov Report

Base: 66.93% // Head: 66.98% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (240568c) compared to base (13321d2).
Patch coverage: 73.68% of modified lines in pull request are covered.

❗ Current head 240568c differs from pull request most recent head 7dcbcb5. Consider uploading reports for the commit 7dcbcb5 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3240      +/-   ##
============================================
+ Coverage     66.93%   66.98%   +0.05%     
- Complexity     4609     4630      +21     
============================================
  Files           252      254       +2     
  Lines         14881    14995     +114     
  Branches        923      938      +15     
============================================
+ Hits           9960    10045      +85     
- Misses         4523     4548      +25     
- Partials        398      402       +4     
Impacted Files Coverage Δ
...main/java/redis/clients/jedis/JedisSentineled.java 44.44% <44.44%> (ø)
.../jedis/providers/SentineledConnectionProvider.java 76.19% <76.19%> (ø)
...nts/jedis/providers/ClusterConnectionProvider.java 75.00% <0.00%> (-3.58%) ⬇️
src/main/java/redis/clients/jedis/Protocol.java 90.62% <0.00%> (-1.25%) ⬇️
...ava/redis/clients/jedis/JedisClusterInfoCache.java 75.62% <0.00%> (+3.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sazzad16 sazzad16 merged commit 0cf061c into redis:master Dec 13, 2022
@sazzad16 sazzad16 deleted the sentinel-unified-1 branch December 13, 2022 10:57
sazzad16 added a commit to sazzad16/jedis that referenced this pull request Aug 31, 2023
This is an expansion of redis#3221, as well as redis#3240. This is requested in redis#3516.
sazzad16 added a commit that referenced this pull request Aug 31, 2023
This is an expansion of #3221, as well as #3240. This is requested in #3516.
sazzad16 added a commit that referenced this pull request Aug 31, 2023
This is an expansion of #3221, as well as #3240. This is requested in #3516.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants