Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup CI on the main branch #306

Closed
duckdoom4 opened this issue May 12, 2023 · 0 comments · Fixed by #308
Closed

Setup CI on the main branch #306

duckdoom4 opened this issue May 12, 2023 · 0 comments · Fixed by #308
Assignees
@LuqueDaniel
Labels
ci/cd

Comments

@duckdoom4
Copy link
Collaborator

duckdoom4 commented May 12, 2023 •
edited
Loading

The dev branch already does this nicely, but the main branch is lacking this feature. Leading to cases where new pr's could contain issues.

Some examples are the missing return and the code style issues in the previously merged pr.
LuqueDaniel added a commit that referenced this issue May 13, 2023
@LuqueDaniel
Adds PR ci to master
e981aa5 
Fixes #306
@LuqueDaniel LuqueDaniel mentioned this issue May 13, 2023
Merged
duckdoom4 added a commit that referenced this issue Jun 2, 2023
@duckdoom4 @a2937
@seanj29 @LuqueDaniel
Merge master into develop (#320)
dabd2b7 
* Chore: Allow 000*.rpy files in renpy/common (#300)

* RunRenpyViaplugin (#291)

* Edited extensions method to add way to run renpy

* Added the command to the pallete via json

* Adding debug config to allow renpy to be played from play button

* changed type to cmd

* reformatted with prettier

* This format might work?

* Refactored if statement to make it more readable

* Refactoring of folder names and chaning if statements

* This commit fixed the issues in comment https://github.com/LuqueDaniel/vscode-language-renpy/pull/291#discussion_r1170180867, , refactoring if statement

* reformated through magical means... God I hate switching computers

* Reformated with the correct file, please ignore previous one

* Ignore dist folder (#303)

* Ignore dist folder (#301)

* Chore(Enhancement) - Add a command that cleans up compiled files.

* Update the command title to match the convention.

* Use await/async syntax

* Adds PR ci to master

Fixes #306

* Fixes codeql-analysis.yml format

* Adds setup action

* Fix package lock after merge

---------

Co-authored-by: a2937 <[email protected]>
Co-authored-by: seanj29 <[email protected]>
Co-authored-by: Daniel Luque <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LuqueDaniel LuqueDaniel

Labels
ci/cd
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds PR Check to master renpy/vscode-language-renpy
2 participants
@LuqueDaniel @duckdoom4