RunRenpyViaplugin #291

seanj29 · 2023-04-12T13:24:46Z

I don't have any expereince with typescript, so it may be a bit of a botched job, and I can't seem to get node.js to run on my machine, but this should be able to deal with https://github.com/LuqueDaniel/vscode-language-renpy/issues/115#issue-1239736338. I used a child process to run terminal command similar to what is done to watch for renpy compile data, but it should spawn a new renpy process in a new window.

duckdoom4 · 2023-04-12T19:55:19Z

Hi there, thank your interest in the project and taking the time to build this PR! :) This is definitely a good start and the code looks good. (I will need to take some time later to test it before I approve the code).

That said, it would be nice if you can link this command to the 'play/run' button. That way we use the default behavior, instead of requiring users to run a command.

duckdoom4 · 2023-04-12T20:10:58Z

I just looked through the documentation for this. I think the only way to do this, is through the debugger API.

https://code.visualstudio.com/api/extension-guides/debugger-extension

In our case, the full debugger is a bit of a stretch. But I think we should be able to use the mock debugger example they provided, then strip out all the debugger options and only provide the launch/run functionality.

Let me know if that's something you'd be willing to help with, or if you'd rather leave it as a command for now. Given that this is a bit more work, I totally understand if you do.

duckdoom4 · 2023-04-12T20:23:01Z

Actually, looking at this:

I think we might be able to add a launch configuration without the debugger. That would be best. In our case the 'type' should then be cmd instead of mock and adding the "command" property. Eg. "command": "run renpy cmd"

Also see this:
https://github.com/microsoft/vscode-mock-debug/blob/63e33ea07d9769ae9605212a13e96796333a61fd/src/activateMockDebug.ts#L30

seanj29 · 2023-04-12T21:07:19Z

I'm happy to try out doing this. Ill read through the vscode extension docs you sent and send an update

LuqueDaniel · 2023-04-12T22:08:44Z

Thank you very much for your contribution. I look forward to testing and reviewing it soon.

duckdoom4 · 2023-04-14T19:56:03Z

I noticed that your formatting is configured to 2 spaces instead of four. Did you use prettier? The .editorconfig does use 4 spaces for ts files. Let me know if that setting doesn't work anymore

seanj29 · 2023-04-15T21:33:11Z

Ill try rerunning it, I should have prettier installed on the machine tho gimme a sec

seanj29 · 2023-04-15T21:40:22Z

Done now. Think my prettier for some reason didn't format the workspace on save like I set it to

duckdoom4 · 2023-04-17T23:05:09Z

That's much better, tho it's still applying two spaces instead of 4 :(

(That makes it really hard to review the changes you've made, git doesn't display those diffs very well)

seanj29 · 2023-04-18T07:00:03Z

I'll try to reformat again, should be able to whitespace diff instead of full diff instead, but hopefully this works.

duckdoom4 · 2023-04-18T07:56:40Z

Yes perfect, that worked. I'll review it in a bit

duckdoom4

Awesome work! Looking really good, some minor things and then we can get this merged! 😄

duckdoom4 · 2023-04-18T09:52:11Z

src/extension.ts

+        if (!config) {
+            window.showErrorMessage("Ren'Py executable location not configured or is invalid.");
+        } else {
+            if (isValidExecutable(config.renpyExecutableLocation)) {


You can move this check to the line above with an || or comparison. (So 'if not config or renpy executable location not set'.) That way you don't need the copy the message log code :)

(Also in case you didn't know, that works because if statements do early out. Meaning the config is checked first, and only if true will it check the remaining parts)

God it, fixed this now

duckdoom4 · 2023-04-18T09:57:50Z

src/extension.ts

+            window.showErrorMessage("Ren'Py executable location not configured or is invalid.");
+        } else {
+            if (isValidExecutable(config.renpyExecutableLocation)) {
+                //this is kinda a hob botched together attempt that I'm like 30% certain has a chance of working


Did you test if it works? If it does you should remove the comment

Did not manage to test if it works yet, will try after this commit

duckdoom4 · 2023-04-18T09:58:33Z

src/extension.ts

+                    window.showInformationMessage("Ren'Py is running successfully");
+                }
+            } else {
+                window.showErrorMessage("Ren'Py executable location not configured or is invalid.");


Remember to remove this one if you addressed my first comment :)

duckdoom4 · 2023-04-18T10:00:50Z

src/extension.ts

+function RunWorkspaceFolder(): boolean {
+    const config = workspace.getConfiguration("renpy");
+    const renpy = config.renpyExecutableLocation;
+    if (isValidExecutable(renpy)) {


Remember that the config can be null, you should use the same check as above.

(Even if you know you checked, if someone in the future wants to use this function, it should be safe to use on it's own)

duckdoom4 · 2023-04-18T10:05:09Z

src/extension.ts

+    if (isValidExecutable(renpy)) {
+        const renpyPath = cleanUpPath(Uri.file(renpy).path);
+        const cwd = renpyPath.substring(0, renpyPath.lastIndexOf("/"));
+        let wf = getWorkspaceFolder();


I see now you copied it from the function below, so no worries. But my feedback should still be applied.

I think this can be const. Also please use full (short) descriptive names for variables. If I want to know what wf means, I now have to look at the definition.

seanj29 · 2023-04-18T12:15:04Z

I can't seem to run the extension tests on my machine? Or at least the secondary checker one you have on there

src/extension.ts

duckdoom4 · 2023-04-18T15:12:48Z

One last thing :p

Sorry, what extension tests are you talking about?
If you mean you want to run the extension, you'll need node.js installed to execute webpack.
To be fair, I've been developing on the dev branch for the longest time. It could very well be that it's broken on main.
(don't have much time to check rn, sorry)

…l/vscode-language-renpy/pull/291#discussion_r1170180867, , refactoring if statement

seanj29 · 2023-04-22T11:35:19Z

Also yeah, I did mean running the extension, I'm installing node.js now lmao, didn't even realize it was needed.

duckdoom4 · 2023-04-22T14:49:09Z

Your last commit converted everything to two spaces again 😁

duckdoom4 · 2023-05-07T19:43:40Z

Yes looking good. LGTM! 🎉🎉

* Edited extensions method to add way to run renpy * Added the command to the pallete via json * Adding debug config to allow renpy to be played from play button * changed type to cmd * reformatted with prettier * This format might work? * Refactored if statement to make it more readable * Refactoring of folder names and chaning if statements * This commit fixed the issues in comment https://github.com/LuqueDaniel/vscode-language-renpy/pull/291#discussion_r1170180867, , refactoring if statement * reformated through magical means... God I hate switching computers * Reformated with the correct file, please ignore previous one

* Chore: Allow 000*.rpy files in renpy/common (#300) * RunRenpyViaplugin (#291) * Edited extensions method to add way to run renpy * Added the command to the pallete via json * Adding debug config to allow renpy to be played from play button * changed type to cmd * reformatted with prettier * This format might work? * Refactored if statement to make it more readable * Refactoring of folder names and chaning if statements * This commit fixed the issues in comment https://github.com/LuqueDaniel/vscode-language-renpy/pull/291#discussion_r1170180867, , refactoring if statement * reformated through magical means... God I hate switching computers * Reformated with the correct file, please ignore previous one * Ignore dist folder (#303) * Ignore dist folder (#301) * Chore(Enhancement) - Add a command that cleans up compiled files. * Update the command title to match the convention. * Use await/async syntax * Merge pull request #304 from a2937/old-file-command Chore(Enhancement) - Add a command that cleans up compiled files. --------- Co-authored-by: a2937 <[email protected]> Co-authored-by: seanj29 <[email protected]> Co-authored-by: Daniel Luque <[email protected]>

* Chore: Allow 000*.rpy files in renpy/common (#300) * RunRenpyViaplugin (#291) * Edited extensions method to add way to run renpy * Added the command to the pallete via json * Adding debug config to allow renpy to be played from play button * changed type to cmd * reformatted with prettier * This format might work? * Refactored if statement to make it more readable * Refactoring of folder names and chaning if statements * This commit fixed the issues in comment https://github.com/LuqueDaniel/vscode-language-renpy/pull/291#discussion_r1170180867, , refactoring if statement * reformated through magical means... God I hate switching computers * Reformated with the correct file, please ignore previous one * Ignore dist folder (#303) * Ignore dist folder (#301) * Chore(Enhancement) - Add a command that cleans up compiled files. * Update the command title to match the convention. * Use await/async syntax * Adds PR ci to master Fixes #306 * Fixes codeql-analysis.yml format * Adds setup action * Fix package lock after merge --------- Co-authored-by: a2937 <[email protected]> Co-authored-by: seanj29 <[email protected]> Co-authored-by: Daniel Luque <[email protected]>

hsandt · 2023-10-31T16:08:28Z

Hey, I'm trying to use the command Run: Renpy: Run Project but it shows me an error:

Ren'Py executable location not configured or is invalid.

I can see that it should be set in config.renpyExecutableLocation in the commit diff, but I see no such setting in Settings > Extensions > Ren'Py (there are only 10 settings, from editor.defaultFoldingRangeProvider to renpy.watchFoldersForChanges).

How am I supposed to set it?

duckdoom4 · 2023-10-31T20:21:22Z

Hi there, I think there might be no UI entry for this (going off your comment). In that case you can only set it manually by adding this entry in the setting json config

hsandt · 2023-11-15T12:19:41Z

Hi there, I think there might be no UI entry for this (going off your comment). In that case you can only set it manually by adding this entry in the setting json config

So, the parameter is not autocompleted and not recognised (it appears half transparent and hovering it shows tooltip "Unknown Configuration Setting") but surprisingly setting it to the full path of renpy.sh (on Linux) actually replaces the "Ren'Py executable location not configured or is invalid." error bottom-right popup with a centered popup window:

Clicking on "Install cmd Extension" will suggest a few bash/command-related extension to install, but it doesn't seem quite right, so I'm not sure what to do now.

For now I just run Renpy via a custom command using F5Anything...

EDIT: since this PR is merged I'll copy this post to #115 to continue discussion.

seanj29 · 2023-12-04T17:14:13Z

I've got some time, so I'm gonna try and remake this in better way, and try to get running working from GUI too.

seanj29 · 2023-12-04T17:16:18Z

realised that its alredy been fixed in #115 oops

seanj29 added 2 commits April 12, 2023 14:06

Edited extensions method to add way to run renpy

73901ae

Added the command to the pallete via json

306eaee

Adding debug config to allow renpy to be played from play button

769b63d

changed type to cmd

32d22a0

reformatted with prettier

8867857

This format might work?

746a9b2

duckdoom4 requested changes Apr 18, 2023

View reviewed changes

seanj29 added 2 commits April 18, 2023 12:55

Refactored if statement to make it more readable

805c75b

Refactoring of folder names and chaning if statements

4961e3a

duckdoom4 requested changes Apr 18, 2023

View reviewed changes

src/extension.ts Outdated Show resolved Hide resolved

This commit fixed the issues in comment https://github.com/LuqueDanie…

b737f72

…l/vscode-language-renpy/pull/291#discussion_r1170180867, , refactoring if statement

seanj29 and others added 2 commits April 22, 2023 20:21

reformated through magical means... God I hate switching computers

cf5d0fd

Reformated with the correct file, please ignore previous one

850dbec

duckdoom4 approved these changes May 7, 2023

View reviewed changes

duckdoom4 merged commit c2bea06 into renpy:master May 7, 2023

LuqueDaniel added this to the 2.0.17 milestone May 7, 2023

LuqueDaniel modified the milestones: 2.0.17, 2.2.0 Jun 3, 2023

hsandt mentioned this pull request Oct 31, 2023

Running renpy through the editor #115

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RunRenpyViaplugin #291

RunRenpyViaplugin #291

seanj29 commented Apr 12, 2023

duckdoom4 commented Apr 12, 2023 •

edited

Loading

duckdoom4 commented Apr 12, 2023 •

edited

Loading

duckdoom4 commented Apr 12, 2023 •

edited

Loading

seanj29 commented Apr 12, 2023

LuqueDaniel commented Apr 12, 2023

duckdoom4 commented Apr 14, 2023

seanj29 commented Apr 15, 2023

seanj29 commented Apr 15, 2023

duckdoom4 commented Apr 17, 2023 •

edited

Loading

seanj29 commented Apr 18, 2023

duckdoom4 commented Apr 18, 2023

duckdoom4 left a comment

duckdoom4 Apr 18, 2023

seanj29 Apr 18, 2023

duckdoom4 Apr 18, 2023

seanj29 Apr 18, 2023

duckdoom4 Apr 18, 2023

duckdoom4 Apr 18, 2023

duckdoom4 Apr 18, 2023 •

edited

Loading

seanj29 commented Apr 18, 2023

duckdoom4 commented Apr 18, 2023

seanj29 commented Apr 22, 2023

duckdoom4 commented Apr 22, 2023

duckdoom4 commented May 7, 2023

hsandt commented Oct 31, 2023

duckdoom4 commented Oct 31, 2023

hsandt commented Nov 15, 2023 •

edited

Loading

seanj29 commented Dec 4, 2023

seanj29 commented Dec 4, 2023

RunRenpyViaplugin #291

RunRenpyViaplugin #291

Conversation

seanj29 commented Apr 12, 2023

duckdoom4 commented Apr 12, 2023 • edited Loading

duckdoom4 commented Apr 12, 2023 • edited Loading

duckdoom4 commented Apr 12, 2023 • edited Loading

seanj29 commented Apr 12, 2023

LuqueDaniel commented Apr 12, 2023

duckdoom4 commented Apr 14, 2023

seanj29 commented Apr 15, 2023

seanj29 commented Apr 15, 2023

duckdoom4 commented Apr 17, 2023 • edited Loading

seanj29 commented Apr 18, 2023

duckdoom4 commented Apr 18, 2023

duckdoom4 left a comment

Choose a reason for hiding this comment

duckdoom4 Apr 18, 2023

Choose a reason for hiding this comment

seanj29 Apr 18, 2023

Choose a reason for hiding this comment

duckdoom4 Apr 18, 2023

Choose a reason for hiding this comment

seanj29 Apr 18, 2023

Choose a reason for hiding this comment

duckdoom4 Apr 18, 2023

Choose a reason for hiding this comment

duckdoom4 Apr 18, 2023

Choose a reason for hiding this comment

duckdoom4 Apr 18, 2023 • edited Loading

Choose a reason for hiding this comment

seanj29 commented Apr 18, 2023

duckdoom4 commented Apr 18, 2023

seanj29 commented Apr 22, 2023

duckdoom4 commented Apr 22, 2023

duckdoom4 commented May 7, 2023

hsandt commented Oct 31, 2023

duckdoom4 commented Oct 31, 2023

hsandt commented Nov 15, 2023 • edited Loading

seanj29 commented Dec 4, 2023

seanj29 commented Dec 4, 2023

duckdoom4 commented Apr 12, 2023 •

edited

Loading

duckdoom4 commented Apr 12, 2023 •

edited

Loading

duckdoom4 commented Apr 12, 2023 •

edited

Loading

duckdoom4 commented Apr 17, 2023 •

edited

Loading

duckdoom4 Apr 18, 2023 •

edited

Loading

hsandt commented Nov 15, 2023 •

edited

Loading