Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test suite #126

Merged
merged 70 commits into from
Oct 13, 2023
Merged

test suite #126

merged 70 commits into from
Oct 13, 2023

Conversation

cdmistman
Copy link
Contributor

cucumber was too much - felt like i was debugging the library more than upm itself

this supercedes #124

@cdmistman cdmistman mentioned this pull request Sep 25, 2023
Closed
Base automatically changed from cad/update-things to main September 26, 2023 18:46
@cdmistman cdmistman mentioned this pull request Oct 12, 2023
Closed
@cdmistman cdmistman marked this pull request as ready for review October 12, 2023 19:28
@cdmistman cdmistman requested a review from a team as a code owner October 12, 2023 19:28
@cdmistman cdmistman requested review from masad-frost and removed request for a team October 12, 2023 19:28
cdmistman
cdmistman commented Oct 12, 2023
View reviewed changes
.semaphore/semaphore.yml Outdated Show resolved Hide resolved
cdmistman
cdmistman commented Oct 12, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
cdmistman
cdmistman commented Oct 12, 2023
View reviewed changes
.semaphore/install_nix.sh Outdated Show resolved Hide resolved
cdmistman
cdmistman commented Oct 12, 2023
View reviewed changes
nix/upm/default.nix Outdated Show resolved Hide resolved
This was referenced Oct 12, 2023
Merged
Merged
Merged
ryantm
ryantm approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this looks like a very thorough job of integration testing UPM! Thank you!

@cdmistman cdmistman merged commit 4b26922 into main Oct 13, 2023
1 check failed
@cdmistman cdmistman deleted the cad/test-suite branch October 13, 2023 21:11
@cdmistman cdmistman mentioned this pull request Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

@masad-frost masad-frost Awaiting requested review from masad-frost masad-frost is a code owner automatically assigned from replit/devex

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdmistman @ryantm @blast-hardcheese