Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn tests #130

Merged
merged 73 commits into from
Oct 20, 2023
Merged

yarn tests #130

merged 73 commits into from
Oct 20, 2023

Conversation

cdmistman
Copy link
Contributor

@cdmistman cdmistman commented Oct 3, 2023

there's a bug with reading @org/package from the lockfile, which is why tests are failing

blocked on #126

@cdmistman cdmistman marked this pull request as ready for review October 12, 2023 19:43
@cdmistman cdmistman requested a review from a team as a code owner October 12, 2023 19:43
@cdmistman cdmistman requested review from airportyh and removed request for a team October 12, 2023 19:43
@cdmistman
Copy link
Contributor Author

😱 failing ci after merge???

@cdmistman
Copy link
Contributor Author

ah crap bad merge

Copy link
Contributor

@airportyh airportyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am getting some test failures:

  • TestAdd/nodejs-yarn/many-deps/unlocked/all
  • TestList/nodejs-yarn/many-deps
  • TestLock/nodejs-yarn

Among them.

Copy link
Contributor

@airportyh airportyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry nm. I didn't have the nix-shell properly setup. Now it works.

@cdmistman cdmistman merged commit 9a5f808 into main Oct 20, 2023
1 check passed
@cdmistman cdmistman deleted the cad/yarn-tests branch October 20, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants