[store] if store.json is empty, don't try to unmarshal it #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantm
force-pushed
the
rtm-12-11-empty-store.json
branch
from
8190bb3
to
a03cf0a
Compare
cdmistman
reviewed
Dec 11, 2023
ryantm
force-pushed
the
rtm-12-11-empty-store.json
branch
from
a03cf0a
to
cbe9ce4
Compare
Why === * We're seeing many error logs with > store.json: unexpected end of JSON input * Looking at the Repls, it appears they have an empty store.json file What changed === * If the store.json file is empty or only whitespace, skip unmarshalling and assume it is empty Test plan === * ran `UPM_STORE=store.json ./result/bin/upm -l nodejs add express` with an empty store.json file before and after the change
ryantm
force-pushed
the
rtm-12-11-empty-store.json
branch
from
cbe9ce4
to
cb724dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
What changed
Test plan
UPM_STORE=store.json ./result/bin/upm -l nodejs add expresswith an empty store.json file before and after the change