Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[store] if store.json is empty, don't try to unmarshal it #177

Merged
merged 1 commit into from
Dec 12, 2023
Merged

[store] if store.json is empty, don't try to unmarshal it #177

merged 1 commit into from
Dec 12, 2023

Commits on Dec 12, 2023

  1. [store] if store.json is empty, don't try to unmarshal it 

    Why
===
* We're seeing many error logs with

> store.json: unexpected end of JSON input

* Looking at the Repls, it appears they have an empty store.json file

What changed
===
* If the store.json file is empty or only whitespace, skip
unmarshalling and assume it is empty

Test plan
===
* ran `UPM_STORE=store.json ./result/bin/upm -l nodejs add express` with an empty store.json file before and after the change
    @ryantm
    ryantm committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    cb724dc View commit details
    Browse the repository at this point in the history