Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataframe v2: fix debug build performance #7703

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Dataframe v2: fix debug build performance #7703

merged 1 commit into from
Oct 12, 2024
+4 −1

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Oct 12, 2024 •
edited
Loading

Just some very paranoid debug assertions.

Before:
image

After:
image

  • yes

@teh-cmc teh-cmc added 🧑‍💻 dev experience developer experience (excluding CI) 📉 performance Optimization, memory use, etc exclude from changelog PRs with this won't show up in CHANGELOG.md feat-dataframe-api Everything related to the dataframe API labels Oct 12, 2024
@teh-cmc teh-cmc merged commit 3cb194b into main Oct 12, 2024
28 of 29 checks passed
@teh-cmc teh-cmc deleted the cmc/dataframev2_debug_speed branch October 12, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md feat-dataframe-api Everything related to the dataframe API 📉 performance Optimization, memory use, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@teh-cmc