Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataframe v2: fix debug build performance #7703

Merged
merged 1 commit into from
Oct 12, 2024
+4 −1
Merged

Dataframe v2: fix debug build performance #7703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion crates/store/re_dataframe/src/query.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,7 +755,10 @@ impl QueryHandle<'_> {
pub fn num_rows(&self) -> u64 {
let num_rows = self.init().unique_index_values.len() as _;

if cfg!(debug_assertions) {
// NOTE: This is too slow to run in practice, even for debug builds.
// Do keep this around though, it does come in handy.
#[allow(clippy::overly_complex_bool_expr)]
if false && cfg!(debug_assertions) {
let expected_num_rows =
self.engine.query(self.query.clone()).into_iter().count() as u64;
assert_eq!(expected_num_rows, num_rows);
Expand Down
Loading