This repository has been archived by the owner on Jun 15, 2023. It is now read-only.
Improve printing of non-callback arguments in Pexp_apply with callbacks #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #212 Sometimes one of the non-callback arguments will break in a function application where the first or last argument is a callback. There might be a single line comment in there, or a multiline string. We want to break all the arguments in this case for readability. **before** ```rescript showDialog( ` Do you really want to leave this workspace? Some more text with detailed explanations... `, danger=true, ~confirmText="Yes, I am sure!", ~onConfirm={() => ()}, ) ``` **after** ```rescript showDialog( ` Do you really want to leave this workspace? Some more text with detailed explanations... `, ~danger=true, ~confirmText="Yes, I am sure!", ~onConfirm={() => ()}, ) ```
IwanKaramazow
force-pushed
the
more-callback-printing-fixes
branch
from
f9c5448
to
f47c1ce
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #212
Sometimes one of the non-callback arguments will break in a function application where the first or last argument is a callback. There might be a single line comment in there, or a multiline string. We want to break all the arguments in this case for readability.
before
after