Skip to content
This repository has been archived by the owner on Jun 15, 2023. It is now read-only.

Improve printing of non-callback arguments in Pexp_apply with callbacks #241

Merged
merged 1 commit into from
Jan 19, 2021

Commits on Jan 19, 2021

  1. Improve printing of non-callback arguments in Pexp_apply with callbacks

    Fix #212
    
    Sometimes one of the non-callback arguments will break in a function application where the first or last argument is a callback. There might be a single line comment in there, or a multiline string. We want to break all the arguments in this case for readability.
    
    **before**
    ```rescript
    showDialog(
      `
      Do you really want to leave this workspace?
      Some more text with detailed explanations...
      `, danger=true, ~confirmText="Yes, I am sure!", ~onConfirm={() => ()},
    )
    ```
    
    **after**
    ```rescript
    showDialog(
      `
      Do you really want to leave this workspace?
      Some more text with detailed explanations...
      `,
      ~danger=true,
      ~confirmText="Yes, I am sure!",
      ~onConfirm={() => ()},
    )
    ```
    Iwan committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    f47c1ce View commit details
    Browse the repository at this point in the history