Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote Lock Interface #29

Merged
merged 10 commits into from
Jan 25, 2024
Merged

Remote Lock Interface #29

merged 10 commits into from
Jan 25, 2024

Conversation

vaibhawvipul
Copy link
Contributor

@vaibhawvipul vaibhawvipul commented Jan 23, 2024

resolves - #25

  • implementation of lock interface in remote mode

@vaibhawvipul vaibhawvipul self-assigned this Jan 23, 2024
@vaibhawvipul vaibhawvipul marked this pull request as draft January 23, 2024 08:27
@guergabo
Copy link
Contributor

guergabo commented Jan 24, 2024

hi @vaibhawvipul, this pr will alter slightly the payload for the acquire and heartbeat apis: resonatehq/resonate#216.

I'd recommend just looking at the openapi file which is up to date in the PR.

If you have any questions lmk.

@vaibhawvipul vaibhawvipul marked this pull request as ready for review January 24, 2024 05:58
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2024

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (bbae2df) 60.73% compared to head (5982bb2) 58.68%.
Report is 2 commits behind head on main.

Files Patch % Lines
lib/core/stores/remote.ts 2.63% 31 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   60.73%   58.68%   -2.06%     
==========================================
  Files          17       16       -1     
  Lines         736      789      +53     
  Branches      176      191      +15     
==========================================
+ Hits          447      463      +16     
- Misses        267      298      +31     
- Partials       22       28       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaibhawvipul vaibhawvipul changed the title [WIP] Lock Interface Remote Lock Interface Jan 24, 2024
lib/core/stores/remote.ts Outdated Show resolved Hide resolved
lib/core/stores/remote.ts Outdated Show resolved Hide resolved
lib/core/stores/remote.ts Outdated Show resolved Hide resolved
@vaibhawvipul vaibhawvipul merged commit a4bc908 into main Jan 25, 2024
1 check passed
@vaibhawvipul vaibhawvipul deleted the remote-lock-sdk branch January 25, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants