Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locks): improve usability by accepting delta #216

Merged
merged 4 commits into from
Jan 24, 2024
Merged

feat(locks): improve usability by accepting delta #216

merged 4 commits into from
Jan 24, 2024

Conversation

guergabo
Copy link
Contributor

No description provided.

@guergabo guergabo requested a review from dfarr January 23, 2024 18:44
@guergabo guergabo self-assigned this Jan 23, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (8ae847f) 64.89% compared to head (8bc7149) 64.33%.

Files Patch % Lines
internal/app/subsystems/api/grpc/api/lock.pb.go 0.00% 7 Missing ⚠️
pkg/lock/record.go 0.00% 5 Missing ⚠️
test/dst/model.go 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
- Coverage   64.89%   64.33%   -0.57%     
==========================================
  Files          94       94              
  Lines       10144    10141       -3     
==========================================
- Hits         6583     6524      -59     
- Misses       3106     3164      +58     
+ Partials      455      453       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guergabo guergabo added the enhancement New feature or request label Jan 24, 2024
@guergabo guergabo merged commit 0773fab into main Jan 24, 2024
6 of 7 checks passed
@guergabo guergabo deleted the use-delta branch January 24, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants