Add Flag to Reset the DB on Shutdown.

[favalos]

Pull request to add the flag discussed in #97.

I had to add a reset flag to every DB configuration and change the Reset implementation.

Other approach could be doing the implementation on the Shutdown method, but that would imply to add a new Resetable() bool method to the subsystem interface.

Please let me know your comments.

[dfarr]

Thank you so much for the contribution @favalos!

I have one (hopefully) small change to ask.

The shutdown function on the api/aio interfaces are used as a signal to begin a graceful shutdown. The aio method is currently unused, but we do use it on the api side. When this signal is received we stop taking new requests but continue to process any sqes/cqes already in the system until all are complete. As such we can't reset the database via the shutdown function as we still need to write to the database after this function has been called.

You can see the shutdown process here.

1. shutdown signal received (happens in a go routine and calls api.shutdown+aio.shutdown via system.Shutdown)
2. system.Loop will return once all outstanding sqes/cqes are complete
3. api.Stop() called
4. aio.Stop() called (internally calls Stop for all subsystems)

I recommend moving the call to Reset (if the flag is true) the Stop function, this is when we can safely reset.

[favalos]

Hi @dfarr,

Thanks for the detailed explanation, I did the changes accordingly.

Let me know if that looks fine.

[guergabo]

Thank you @favalos for contributing to resonate !!!

[codecov]

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (d4fb16c) 64.85% compared to head (ca6cdcd) 64.81%.

Files	Patch %	Lines
...rnal/app/subsystems/aio/store/postgres/postgres.go	33.33%	3 Missing and 1 partial ⚠️
internal/app/subsystems/aio/store/sqlite/sqlite.go	33.33%	3 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
- Coverage   64.85%   64.81%   -0.05%     
==========================================
  Files          83       83              
  Lines        8829     8841      +12     
==========================================
+ Hits         5726     5730       +4     
- Misses       2709     2715       +6     
- Partials      394      396       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dfarr]

Looks great! Thank you @favalos

[dfarr]

Closes #97