Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flag to Reset the DB on Shutdown. #202

Merged
merged 4 commits into from
Jan 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cmd/serve/serve.go
Original file line number Diff line number Diff line change
Expand Up @@ -192,12 +192,14 @@ func ServeCmd() *cobra.Command {
cmd.Flags().Int("aio-store-batch-size", 100, "max submissions processed each tick by a store worker")
cmd.Flags().String("aio-store-sqlite-path", "resonate.db", "sqlite database path")
cmd.Flags().Duration("aio-store-sqlite-tx-timeout", 250*time.Millisecond, "sqlite transaction timeout")
cmd.Flags().Bool("aio-store-sqlite-reset", false, "sqlite database clean on shutdown")
cmd.Flags().String("aio-store-postgres-host", "localhost", "postgres host")
cmd.Flags().String("aio-store-postgres-port", "5432", "postgres port")
cmd.Flags().String("aio-store-postgres-username", "", "postgres username")
cmd.Flags().String("aio-store-postgres-password", "", "postgres password")
cmd.Flags().String("aio-store-postgres-database", "resonate", "postgres database name")
cmd.Flags().Duration("aio-store-postgres-tx-timeout", 250*time.Millisecond, "postgres transaction timeout")
cmd.Flags().Bool("aio-store-postgres-reset", false, "postgres database clean on shutdown")
cmd.Flags().Int("aio-network-size", 100, "size of network submission queue buffered channel")
cmd.Flags().Int("aio-network-workers", 3, "number of concurrent http requests")
cmd.Flags().Int("aio-network-batch-size", 100, "max submissions processed each tick by a network worker")
Expand All @@ -210,13 +212,15 @@ func ServeCmd() *cobra.Command {
_ = viper.BindPFlag("aio.subsystems.store.subsystem.batchSize", cmd.Flags().Lookup("aio-store-batch-size"))
_ = viper.BindPFlag("aio.subsystems.store.config.sqlite.path", cmd.Flags().Lookup("aio-store-sqlite-path"))
_ = viper.BindPFlag("aio.subsystems.store.config.sqlite.txTimeout", cmd.Flags().Lookup("aio-store-sqlite-tx-timeout"))
_ = viper.BindPFlag("aio.subsystems.store.config.sqlite.reset", cmd.Flags().Lookup("aio-store-sqlite-reset"))
_ = viper.BindPFlag("aio.subsystems.store.config.postgres.host", cmd.Flags().Lookup("aio-store-postgres-host"))
_ = viper.BindPFlag("aio.subsystems.store.config.postgres.port", cmd.Flags().Lookup("aio-store-postgres-port"))
_ = viper.BindPFlag("aio.subsystems.store.config.postgres.username", cmd.Flags().Lookup("aio-store-postgres-username"))
_ = viper.BindPFlag("aio.subsystems.store.config.postgres.password", cmd.Flags().Lookup("aio-store-postgres-password"))
_ = viper.BindPFlag("aio.subsystems.store.config.postgres.database", cmd.Flags().Lookup("aio-store-postgres-database"))
_ = viper.BindPFlag("aio.subsystems.store.config.postgres.database", cmd.Flags().Lookup("aio-store-postgres-database"))
_ = viper.BindPFlag("aio.subsystems.store.config.postgres.txTimeout", cmd.Flags().Lookup("aio-store-postgres-tx-timeout"))
_ = viper.BindPFlag("aio.subsystems.store.config.postgres.reset", cmd.Flags().Lookup("aio-store-postgres-reset"))
_ = viper.BindPFlag("aio.subsystems.network.subsystem.size", cmd.Flags().Lookup("aio-network-size"))
_ = viper.BindPFlag("aio.subsystems.network.subsystem.workers", cmd.Flags().Lookup("aio-network-workers"))
_ = viper.BindPFlag("aio.subsystems.network.subsystem.batchSize", cmd.Flags().Lookup("aio-network-batch-size"))
Expand Down
9 changes: 9 additions & 0 deletions internal/app/subsystems/aio/store/postgres/postgres.go
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,7 @@
Password string
Database string
TxTimeout time.Duration
Reset bool
}

type PostgresStore struct {
Expand Down Expand Up @@ -355,10 +356,18 @@
}

func (s *PostgresStore) Stop() error {

if s.config.Reset {
if err := s.Reset(); err != nil {
return err
}

Check warning on line 363 in internal/app/subsystems/aio/store/postgres/postgres.go

View check run for this annotation

Codecov / codecov/patch

internal/app/subsystems/aio/store/postgres/postgres.go#L361-L363

Added lines #L361 - L363 were not covered by tests
}

return s.db.Close()
}

func (s *PostgresStore) Reset() error {

if _, err := s.db.Exec(DROP_TABLE_STATEMENT); err != nil {
return err
}
Expand Down
9 changes: 9 additions & 0 deletions internal/app/subsystems/aio/store/sqlite/sqlite.go
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,7 @@
type Config struct {
Path string
TxTimeout time.Duration
Reset bool
}

type SqliteStore struct {
Expand Down Expand Up @@ -332,10 +333,18 @@
}

func (s *SqliteStore) Stop() error {

if s.config.Reset {
if err := s.Reset(); err != nil {
return err
}

Check warning on line 340 in internal/app/subsystems/aio/store/sqlite/sqlite.go

View check run for this annotation

Codecov / codecov/patch

internal/app/subsystems/aio/store/sqlite/sqlite.go#L338-L340

Added lines #L338 - L340 were not covered by tests
}

return s.db.Close()
}

func (s *SqliteStore) Reset() error {

if _, err := os.Stat(s.config.Path); err != nil {
return nil
}
Expand Down