Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DST fault injection bug fix #267

Merged
merged 24 commits into from
Apr 10, 2024
Merged

DST fault injection bug fix #267

merged 24 commits into from
Apr 10, 2024

Conversation

vaibhawvipul
Copy link
Contributor

@vaibhawvipul vaibhawvipul commented Mar 27, 2024

  • handle aio errors
  • add assertions (fixes - issue 266)

@vaibhawvipul vaibhawvipul self-assigned this Mar 27, 2024
internal/aio/aio_dst.go Show resolved Hide resolved
internal/aio/aio_dst.go Outdated Show resolved Hide resolved
test/dst/model.go Outdated Show resolved Hide resolved
test/dst/dst_test.go Outdated Show resolved Hide resolved
test/dst/dst.go Outdated Show resolved Hide resolved
@guergabo
Copy link
Contributor

fyi: we had pair programming session this morning and few additional things were discovered / discussed. In particular the handling of failure injection post-process. Since the model will encounter reads that it was not aware of since the client believed the AIOStoreFailure occurred. Good stuff!

internal/aio/aio_dst.go Outdated Show resolved Hide resolved
internal/kernel/scheduler/scheduler.go Show resolved Hide resolved
internal/kernel/scheduler/scheduler.go Outdated Show resolved Hide resolved
test/dst/model.go Outdated Show resolved Hide resolved
@vaibhawvipul vaibhawvipul requested review from dfarr and removed request for dtornow April 4, 2024 10:31
test/dst/dst.go Outdated Show resolved Hide resolved
test/dst/model.go Outdated Show resolved Hide resolved
cmd/dst/run.go Outdated Show resolved Hide resolved
cmd/dst/run.go Outdated Show resolved Hide resolved
cmd/dst/run.go Outdated Show resolved Hide resolved
internal/aio/aio_dst.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 63.70%. Comparing base (2ff886c) to head (681718b).
Report is 1 commits behind head on main.

Files Patch % Lines
test/dst/model.go 15.15% 20 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
+ Coverage   62.27%   63.70%   +1.43%     
==========================================
  Files         113      113              
  Lines        9706     9717      +11     
==========================================
+ Hits         6044     6190     +146     
+ Misses       3169     3070      -99     
+ Partials      493      457      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaibhawvipul vaibhawvipul merged commit b014b24 into main Apr 10, 2024
4 of 5 checks passed
@vaibhawvipul vaibhawvipul deleted the issue-246-bug-fix branch April 10, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants