add --version option to the rootCmd

[N4r35h]

resolves issue #298

its already built into cobra just needed to add the Version string to the rootCommand

[guergabo]

Hi @N4r35h,

Thanks for this! I was thinking of using go's build process for this issue instead and pass the versioning information to the linker via ldflags. That way it's not so static and we can configure it externally from a github workflow. Otherwise, we have to modify the source code for each build.

It could default to dev or something of the sorts.

Feel free to explore this route and update this PR. Thanks.

[N4r35h]

sure @guergabo,
i have made the changes please refer to the image and let me know if we should add something else or change things around

i added the vsc.version (automatically set by go build) which is the commit hash also feeling it might be useful where we distribute dev versions of the build for testing and want to correlate to the particular commit also seen it done by the docker cli, we can add more info such as version of golang it was compiled with and built time if required

could you explain about the github release workflow or confirm if thats being used right now ?

go build -ldflags="-X github.com/resonatehq/resonate/cmd/version.Version=v0.5.0"

[guergabo]

no need to make a whole command out of this a variable should do. check this out: https://www.digitalocean.com/community/tutorials/using-ldflags-to-set-version-information-for-go-applications

[guergabo]

the behavior should still remain using the cobra version flag: resonate --version

[guergabo]

regarding the github release workflow, it starts here: https://github.com/resonatehq/resonate/blob/main/.github/workflows/release.yaml

let me take a look in the morning and suggest some follow up actions, because we would want the version information passed to both our docker image release build & github release artifact build

[guergabo]

ok, for docker image release build:

• most likely --build-arg should do the job and use environment variables (the ARG keyword) for this build: https://github.com/resonatehq/resonate/blob/main/Dockerfile#L7

for github release build:

• we just switched to nix and the ldflags are passed here: https://github.com/resonatehq/resonate/blob/main/flake.nix#L88
• for this i want to defer to @lucperkins to suggest the best approach to pass an argument.

[N4r35h]

thanks for pointing out the flake.nix file

i have made the requested changes consider it a draft let me know if anything else is required
i will look into setting this into the workflow in a while

[guergabo]

check out the link i sent before, i'll paste here again: https://www.digitalocean.com/community/tutorials/using-ldflags-to-set-version-information-for-go-applications

this whole function is not needed.