feat(version): append commit hash on build via ldflags #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@guergabo based on all the discussions on the other two PRs, IMO this will work. Although the nix part has to be checked as I'm not too familiar with nix syntax. |
khos2ow
force-pushed
the
version-cmd
branch
2 times, most recently
from
d3a0d22
to
264019d
Compare
It standardize resonate binary version to: resonate version v<VERSION>[-<PRE_RELEASE>-<TIMESTAMP>][ COMMIT_HASH] <GOOS>/<GOARCH> where: - `VERSION`: the release version - `PRE_RELEASE`: can be any arbitrary string, e.g. `alpha`, `beta`, `rc.1`, etc - `TIMESTAMP`: the yyyymmdd of build IF this is not a GA release - `COMMIT_HASH`: short revision IF this is a GA release - `GOOS`: underlying OS this binary built on - `GOARCH`: underlying Architecture this binary built on This also adds a new `version` subcommand for convenience and to not give an error on `resonate version` for folks with muscle memory for it. Signed-off-by: Khosrow Moossavi <[email protected]>
khos2ow
commented
May 29, 2024
| @@ -34,7 +34,6 @@ jobs: | |||
| run: | | |||
| # Extract resonate version | |||
| RESONATE_VERSION=$(./resonate -v | awk '{print $3}') | |||
| RESONATE_VERSION="v${RESONATE_VERSION}" | |||
There was a problem hiding this comment.
This will solve the workflow, but I'm not aware of any other breaking change that this might introduce in the broader resonate landscape, if any. Because effectively resonate --version will always have a leading v and tailing <os>/<arch>, if move forward with this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up the attempts on #301 and #302.
It standardize resonate binary version to:
resonate version v<VERSION>[-<PRE_RELEASE>-<TIMESTAMP>][ COMMIT_HASH] <GOOS>/<GOARCH>where:
VERSION: the release versionPRE_RELEASE: can be any arbitrary string, e.g.alpha,beta,rc.1, etcTIMESTAMP: the yyyymmdd of build IF this is not a GA releaseCOMMIT_HASH: short revision IF this is a GA releaseGOOS: underlying OS this binary built onGOARCH: underlying Architecture this binary built onThis also adds a new
versionsubcommand for convenience and to not give an error onresonate versionfor folks with muscle memory for it.Two manual intervention is needed for this workflow:
coreVersionininternal/version/version.goto next logical releaseprereleasetoalpha(ordev, or similar) ininternal/version/version.goprerleaseto""ininternal/version/version.gofor GA, or just leave it as is for the restThe rest will be calculated, or generated on the fly.
Fixes: #298