Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of basic Auth functionality as mentioned in issue Basic Auth #330 #333

Closed
wants to merge 7 commits into from

Conversation

hkiiita
Copy link
Contributor

@hkiiita hkiiita commented May 20, 2024

Addition of basic Auth functionality as mentioned in issue Basic Auth #330

@hkiiita
Copy link
Contributor Author

hkiiita commented May 20, 2024

Incorporates multiple users.

@hkiiita hkiiita mentioned this pull request May 20, 2024
@dfarr
Copy link
Member

dfarr commented May 21, 2024

Thank you so much for the PR @hkiiita 🎉

We can't believe it, but we actually got two PRs for the same feature. We are going to merge #332, but would you be up for incorporating multiple users (which is lacking in #332) once that one is merged?

@hkiiita
Copy link
Contributor Author

hkiiita commented May 21, 2024

Thank you so much for the PR @hkiiita 🎉

We can't believe it, but we actually got two PRs for the same feature. We are going to merge #332, but would you be up for incorporating multiple users (which is lacking in #332) once that one is merged?

Hi @dfarr thank you so much for your kind reply on this. Yes , i will be more than happy to continue to work on this after 332 gets merged. I have already incorporated multiple users authentication into my PR #333 , so will wait on your side for a review and further steps. Thanks again !

@dfarr
Copy link
Member

dfarr commented May 28, 2024

Hey @hkiiita, PR #332 has been merged, if you're still up for it, we could extend basic auth to support multiple users - I believe we would want to extend these arguments to take an array of username/password combos (and propagate that array down accordingly)

@dfarr dfarr closed this May 28, 2024
@hkiiita
Copy link
Contributor Author

hkiiita commented Jun 6, 2024

Hi @dfarr , thanks for the reply . Yes I definitely would want to work on this . Just wanted to share that, if you are ok with it , I will reach out to you on 18th June.

@hkiiita
Copy link
Contributor Author

hkiiita commented Jun 19, 2024

#352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants