-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic Auth for multiple users. #352
Conversation
@dfarr Please have a look. |
Sorry for the delay in reviewing @hkiiita , this looks great! I have one request, rather than have a separate file for username/password information could we change this to use the default configuration file? The file could look like this: auth:
- username: user1
password: pass1
- username: user2
password: pass2 |
Thanks for having a look @dfarr ; please review the new changes. I have removed the separate creds file as asked and am now reading credentials from the main config file itself. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #352 +/- ##
==========================================
- Coverage 58.12% 58.10% -0.03%
==========================================
Files 113 113
Lines 9943 9938 -5
==========================================
- Hits 5779 5774 -5
Misses 3796 3796
Partials 368 368 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @hkiiita! Now that we are using viper for the configuration we shouldn't need to do manual parsing of the configuration, as long as we specify the type I believe viper will parse automatically for us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Thank you so much @dfarr for the journey. I definitely learned a couple of things during this. Thanks again ! |
This PR adresses Basic Auth #330 for multiple users. Please review.