Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enqueue one task per root_promise_id #448

Merged
merged 13 commits into from
Nov 12, 2024
Merged

Conversation

avillega
Copy link
Contributor

@avillega avillega commented Nov 1, 2024

Enqueue a single task per root_promise_id. This is necessary to prevent extra work happening for a single promise id.

@avillega avillega requested a review from dfarr November 1, 2024 21:10
@avillega
Copy link
Contributor Author

avillega commented Nov 1, 2024

@dfarr I am still unsure how to add dst to this change, any pointers will be appreciated.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 50.58824% with 84 lines in your changes missing coverage. Please review.

Project coverage is 55.34%. Comparing base (2d900b9) to head (a769ca4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/app/subsystems/aio/store/sqlite/sqlite.go 67.24% 17 Missing and 2 partials ⚠️
internal/app/coroutines/enqueueTasks.go 26.08% 17 Missing ⚠️
...rnal/app/subsystems/aio/store/postgres/postgres.go 69.64% 15 Missing and 2 partials ⚠️
pkg/task/record.go 0.00% 13 Missing ⚠️
test/dst/dst.go 0.00% 9 Missing ⚠️
internal/app/subsystems/aio/store/store.go 0.00% 7 Missing ⚠️
internal/kernel/t_aio/store.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #448      +/-   ##
==========================================
+ Coverage   55.28%   55.34%   +0.06%     
==========================================
  Files         119      119              
  Lines       13753    13872     +119     
==========================================
+ Hits         7603     7678      +75     
- Misses       5686     5726      +40     
- Partials      464      468       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dfarr
Copy link
Member

dfarr commented Nov 7, 2024

Sorry for being anal here:

enqueable ->
enqueueable

Copy link
Member

@dfarr dfarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@avillega avillega merged commit ed75208 into main Nov 12, 2024
28 of 29 checks passed
avillega added a commit that referenced this pull request Nov 13, 2024
avillega added a commit that referenced this pull request Nov 13, 2024
@avillega avillega deleted the avillega/enque-one-task-per-root branch November 14, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants