Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Enqueue one task per root_promise_id" #457

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

avillega
Copy link
Contributor

Reverts #448

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 22.00000% with 39 lines in your changes missing coverage. Please review.

Project coverage is 55.28%. Comparing base (ed75208) to head (e911a42).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/app/subsystems/aio/store/sqlite/sqlite.go 13.33% 13 Missing ⚠️
pkg/task/record.go 0.00% 12 Missing ⚠️
...rnal/app/subsystems/aio/store/postgres/postgres.go 15.38% 11 Missing ⚠️
internal/app/coroutines/enqueueTasks.go 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
- Coverage   55.37%   55.28%   -0.10%     
==========================================
  Files         119      119              
  Lines       13872    13753     -119     
==========================================
- Hits         7682     7603      -79     
+ Misses       5723     5686      -37     
+ Partials      467      464       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avillega avillega merged commit 1577567 into main Nov 13, 2024
4 of 6 checks passed
@avillega avillega deleted the revert-448-avillega/enque-one-task-per-root branch November 14, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant