Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depending on the event ordering, the completion might be sent twice for awakeables #1972

Closed
slinkydeveloper opened this issue Sep 18, 2024 · 0 comments · Fixed by #1973
Closed

Depending on the event ordering, the completion might be sent twice for awakeables #1972

slinkydeveloper opened this issue Sep 18, 2024 · 0 comments · Fixed by #1973
Assignees
@slinkydeveloper
Labels
bug Something isn't working partition-processor

Comments

@slinkydeveloper
Copy link
Contributor

This can happen when the invocation is in invoked state, and the user sends twice the completion.
@slinkydeveloper slinkydeveloper added bug Something isn't working partition-processor labels Sep 18, 2024
@slinkydeveloper slinkydeveloper self-assigned this Sep 18, 2024
slinkydeveloper added a commit to slinkydeveloper/restate that referenced this issue Sep 18, 2024
@slinkydeveloper
Test to reproduce restatedev#1972
241bcdf
slinkydeveloper added a commit to slinkydeveloper/restate that referenced this issue Sep 18, 2024
@slinkydeveloper
Fix restatedev#1972.
a2b60a4 
I shuffled around the code of store_completion (there was an indirection not needed)
@slinkydeveloper slinkydeveloper mentioned this issue Sep 18, 2024
Merged
slinkydeveloper added a commit to slinkydeveloper/restate that referenced this issue Sep 18, 2024
@slinkydeveloper
Fix restatedev#1972.
b666d60 
I shuffled around the code of store_completion (there was an indirection not needed)
slinkydeveloper added a commit that referenced this issue Sep 18, 2024
@slinkydeveloper
Make sure we don't send the awakeable completion twice (#1973)
be0b332 
Fix #1972
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slinkydeveloper slinkydeveloper

Labels
bug Something isn't working partition-processor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make sure we don't send the awakeable completion twice slinkydeveloper/restate
1 participant
@slinkydeveloper