Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we don't send the awakeable completion twice #1973

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

slinkydeveloper
Copy link
Contributor

Fix #1972

I shuffled around the code of store_completion (there was an indirection not needed)
Copy link
Contributor

@AhmedSoliman AhmedSoliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this.

@slinkydeveloper slinkydeveloper merged commit be0b332 into restatedev:main Sep 18, 2024
9 checks passed
@slinkydeveloper slinkydeveloper deleted the issues/1972 branch September 18, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Depending on the event ordering, the completion might be sent twice for awakeables
2 participants